feat(staff page)-switch layout with ccip #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a custom-layout and modify page staff
✅ Deploy Preview for ephemeral-sable-89c7e0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Gotta figure out how to switch the layout with token, and which CCIP token meant to be the key. |
add if/else to switch layout with ccip in query
SivanYeh
changed the title
SivanYeh
changed the title
josix
requested changes
Jul 24, 2023
mattwang44
reviewed
Jul 24, 2023
mattwang44
reviewed
Jul 24, 2023
related feature that related to #299
yungshenglu
reviewed
Aug 16, 2023
Comment on lines
+25
to
+31
| font-size: 20px; | ||
| word-spacing: 1px; | ||
| -ms-text-size-adjust: 100%; | ||
| -webkit-text-size-adjust: 100%; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| -webkit-font-smoothing: antialiased; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
Minor: 如果可以用 tailwind 的語法代換，可以直接用。太複雜就維持現這樣
There was a problem hiding this comment.
好建議! 不過我的tailwind還不夠純熟. 先維持這樣. 之後再開一個PR改語法
yungshenglu
reviewed
Aug 16, 2023
mattwang44
approved these changes
Aug 17, 2023
josix
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a custom layout "ccip" to hide footer and header at page staff, switch the layout based on CCIP value
Steps to Test This Pull Request
Expected behavior
When ccip is true, footer and header are hidden as picture:
If false:
Related Issue
#413